SIL: Don't canonicalize struct field and enum element types against the wrong signature #33419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he wrong signature The replacement types of the substitution map are either going to be contextual types, or interface types using some generic signature. There is no requirement that this generic signature is the generic signature of the type declaration itself. By using the generic signature of the type declaration, we could incorrectly canonicalize generic parameters to concrete types if the type itself was defined in a constrained extension, as in the test case here. Fixes <rdar://problem/65272763>.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test Linux |
|
Hm, I'm surprised this doesn't regress anything, but if it passes the test and compatibility suite, OK. |
jckarter
approved these changes
Aug 12, 2020
|
@jckarter I think you were right that this extra canonicalization step was papering over other bugs that were fixed when y'all refactored this to be more principled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replacement types of the substitution map are either going
to be contextual types, or interface types using some generic
signature. There is no requirement that this generic signature
is the generic signature of the type declaration itself.
By using the generic signature of the type declaration, we
could incorrectly canonicalize generic parameters to concrete
types if the type itself was defined in a constrained extension,
as in the test case here.
Fixes rdar://problem/65272763.