[metadata prespecialization] Add canonical prespecialization to end of type descriptors. #33442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was possible to alias an old LinkEntity which was marked used (i.e. in LLVMUsed) or compiler used (i.e. in LLVMCompilerUsed). The result of defining such an alias was a failure downstream when writing out the lists of globals. Here, the old value is removed from the list before it is invalidated.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
nate-chandler
force-pushed
the
generic-metadata-prespecialization-components/record-canonical-prespecializations
branch
from
e0da2f8 to
7069f4b
Compare
|
@swift-ci please test |
Previously, a call to emitMethodLookupFunction or emitDispatchThunk would always simply emit a function, even if it had previously been emitted. That was a problem since these emissions are triggered by emitting class type context descriptors which can now be lazily reemitted upon encountering prespecialized metadata. Here, that behavior is changed to delete the old body, if any, before emitting the body again.
Previously, emitting the descriptor for a nonoverride method always simply emitted, even if it had previously been emitted. That was not a problem before, but is now that class type context descriptors can be reemitted upon encountering metadata prespecializations. Here, the behavior is changed to delete the old definition before emitting the new definition.
The attachment of the canonical prespecializations to the generic type will enable runtime functions to look through the canonical prespecializations in order to return them (getGenericMetadata) and register them with the runtime (getSpecializedGenericMetadata).
The metadata accessor and type context descriptor for a nominal type both depend on canonical metadata--the former because it returns those metadata, the latter because it has them as trailing objects. Here, the work is done to reemit those values when new canonical prespecialized metadata are encountered.
Previously, noncanonical records were only allowed if one of the arguments was from the module where the record was to be emitted. Here, that restriction is lifted. Now getSpecializedGenericMetadata will, on first run, register all canonical metadata with the global cache before attempting to bless the passed-in noncanonical record, allowing noncanonical records to be for the same arguments as a canonical record (since in the case that a canonical record does exist, it will be returned).
nate-chandler
force-pushed
the
generic-metadata-prespecialization-components/record-canonical-prespecializations
branch
from
7069f4b to
5114f22
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test windows |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test macos |
|
@swift-ci please test windows |
nate-chandler
deleted the
generic-metadata-prespecialization-components/record-canonical-prespecializations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enumerating the canonical prespecializations at the end of the type descriptors enables both (1) lifting one of the limitations on cross-module prespecializations and also (2) lifting the logic for iterating through the canonical prespecializations from individual metadata accessors into getGenericMetadata.