[AutoDiff] Fix PullbackCloner tangent value category mismatch crash
#33512
Conversation
Fix semantic member getter pullback generation crash due to tangent value category mismatch. Resolves SR-13411.
|
cc @dan-zheng |
| @@ -2431,7 +2431,7 @@ bool PullbackCloner::Implementation::runForSemanticMemberGetter() { | |||
|
|
|||
| // Switch based on the base tangent struct's value category. | |||
| // TODO(TF-1255): Simplify using unified adjoint value data structure. | |||
| switch (tangentVectorSILTy.getCategory()) { | |||
| switch (getTangentValueCategory(origSelf)) { | |||
| case SILValueCategory::Object: { | |||
| auto adjResult = getAdjointValue(origEntry, origResult); | |||
There was a problem hiding this comment.
Note: hypothetically, there may be a similar "tangent value category mismatch" hole on this line where getAdjointValue(origEntry, origResult) is called before checking that getTangentValueCategory(origResult) == SILValueCategory::Object.
I can't think of a trigger for this in practice (semantic member getter pullback generation for origSelf with object tangent value category but origResult with address tangent value category), so I think it's fine to skip it for now.
| @@ -407,6 +407,7 @@ static CanSILFunctionType getAutoDiffDifferentialType( | |||
| // result's convention is indirect. | |||
| if (tl.isAddressOnly() && !isIndirectFormalResult(origResConv)) { | |||
| switch (origResConv) { | |||
| case ResultConvention::Unowned: | |||
There was a problem hiding this comment.
Note: we could make this logic handle all ResultConvention cases.
But with this change, the three common ResultConvention cases are all handed (Unowned, Owned, Indirect). I haven't seen the other cases (UnownedInnerPointer, Autoreleased) appear in practice.
|
@swift-ci Please smoke test |
Fix semantic member getter pullback generation crash due to tangent value category mismatch.
Resolves SR-13411.