Fallback to building Cmake from source on all platforms, not just Linux #33543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test macOS |
|
Build failed |
|
@swift-ci Please teste |
|
Build failed |
|
Build failed |
CodaFi
added a commit
to CodaFi/swift
that referenced
this pull request
Aug 30, 2020
…just Linux (swiftlang#33543)" This reverts commit 539b241.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, build-script will automatically build cmake if the source is available and there is no suitable cmake already installed.
There is no reason I can see to limit this behavior to Linux, so let's enable it everywhere.