[Package] When building a toolchain, don't copy the Resource directory. #33598
Conversation
Should dramatically improve the size of the snapshost produced, as we don't have stdlib et similia included twice. Also, it helps when producing fat binaries, as we don't have to implement any mechanism for sandwiching all the slices together.
|
@swift-ci build toolchain |
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
I think this works, but I'll wait for Adrian or Mishal to take a look. |
|
(Incidentally, I noticed that we compile with |
|
macOS Toolchain Install command |
| @@ -1234,6 +1234,11 @@ verbose-build | |||
| build-ninja | |||
| build-swift-stdlib-unittest-extra | |||
|
|
|||
| # When producing a package, don't copy the Swift Resource/ directory. | |||
| # This is mainly a space optimization. | |||
There was a problem hiding this comment.
# When building for an Xcode toolchain, don't copy the Swift Resource/ directory into the LLDB.framework. LLDB.framework will be installed alongside a Swift compiler, so LLDB should use its resource directory directly.
There was a problem hiding this comment.
I'll modify this before committing.
|
@swift-ci test |
@dcci knows this, but for those following along from home I want to point out that on Darwin, the size of the debug info does not affect the code size since the debug info is stored separately from the executable. On ELF (Linux), however, it will affect the final binary size. |
|
Comment fixed in: |
Should dramatically improve the size of the snapshost produced,
as we don't have stdlib et similia included twice. Also, it helps when
producing fat binaries, as we don't have to implement any mechanism
for sandwiching all the slices together.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.