[Sema] Improve diagnostics for key path root type inferred as option accessing wrapped member #33603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Windows Platform |
1 similar comment
|
@swift-ci Please smoke test Windows Platform |
theblixguy
reviewed
Aug 24, 2020
LucianoPAlmeida
force-pushed
the
SR-13079-improve-kp-optional-root-diagnostics
branch
2 times, most recently
from
4c8e8e7 to
b4bd3a7
Compare
xedin
approved these changes
Aug 24, 2020
theblixguy
reviewed
Aug 24, 2020
rintaro
reviewed
Aug 24, 2020
LucianoPAlmeida
force-pushed
the
SR-13079-improve-kp-optional-root-diagnostics
branch
from
b4bd3a7 to
87dac43
Compare
|
Just adjusted for adding both |
LucianoPAlmeida
force-pushed
the
SR-13079-improve-kp-optional-root-diagnostics
branch
from
87dac43 to
f6f611a
Compare
hamishknight
approved these changes
Aug 27, 2020
|
@swift-ci Please smoke test |
…accessing wrapped member
LucianoPAlmeida
force-pushed
the
SR-13079-improve-kp-optional-root-diagnostics
branch
from
f6f611a to
4b921c3
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Windows Platform |
|
@swift-ci Please smoke test MacOS platform |
LucianoPAlmeida
deleted the
SR-13079-improve-kp-optional-root-diagnostics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve diagnostics for key path root type inferred as option accessing wrapped member to emphasizes that the problem is with the key path's root type being inferred as an optional.
Resolves SR-13079.