Skip to content

Use defined(_POSIX_THREADS) to detect pthread support #33609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2020
Merged

Use defined(_POSIX_THREADS) to detect pthread support #33609

merged 2 commits into from
Aug 25, 2020

Conversation

kubamracek
Copy link
Contributor

No description provided.

@kubamracek kubamracek requested a review from compnerd August 24, 2020 15:30
@kubamracek kubamracek mentioned this pull request Aug 24, 2020
Merged
@kubamracek
Copy link
Contributor Author

@swift-ci please test

compnerd
compnerd approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for cleaning this up!

benrimmington
benrimmington reviewed Aug 24, 2020
View reviewed changes
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 939c140

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 939c140

@kubamracek @benrimmington
Guard unistd.h inclusion
444e9ae 
Co-authored-by: Ben Rimmington <[email protected]>
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@benrimmington
Copy link
Contributor

@swift-ci Please test Windows platform

@kubamracek kubamracek merged commit 76da9a0 into master Aug 25, 2020
@kubamracek kubamracek deleted the posix_threads branch August 25, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benrimmington benrimmington benrimmington left review comments

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kubamracek @swift-ci @benrimmington @compnerd