Skip to content

[CSApply] Handle OptionalForce component when is initial component on key path expr #33623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2020
Merged

[CSApply] Handle OptionalForce component when is initial component on key path expr #33623

merged 1 commit into from
Aug 26, 2020

Conversation

LucianoPAlmeida
Copy link
Contributor

Fixing crash when ForceOptional kind is the first component on CSApply.

Resolves SR-13442.

@LucianoPAlmeida LucianoPAlmeida force-pushed the SR-13442-key-path-unwrap-crash branch from fd64729 to 5fc9008 Compare August 25, 2020 02:54
hamishknight
hamishknight reviewed Aug 25, 2020
View reviewed changes
@LucianoPAlmeida LucianoPAlmeida force-pushed the SR-13442-key-path-unwrap-crash branch 2 times, most recently from 2f310f4 to 2c65ee5 Compare August 25, 2020 12:25
@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci Please smoke test

hamishknight
hamishknight reviewed Aug 25, 2020
View reviewed changes
Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor comment, but this looks good to me!

@LucianoPAlmeida LucianoPAlmeida force-pushed the SR-13442-key-path-unwrap-crash branch from 2c65ee5 to 7815ecf Compare August 25, 2020 22:31
hamishknight
hamishknight approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci Please smoke test

@LucianoPAlmeida
Copy link
Contributor Author

Something wrong with the build? It still not triggered 🤔
Should we try again or just wait a bit more?

@hamishknight
Copy link
Contributor

hamishknight commented Aug 25, 2020 •
edited
Loading

Looks like it didn't get triggered. This can sometimes happen after a force-push, usually waiting a little bit and re-trying fixes it.

@swift-ci please smoke test

@LucianoPAlmeida LucianoPAlmeida merged commit 97609dd into swiftlang:master Aug 26, 2020
@LucianoPAlmeida LucianoPAlmeida deleted the SR-13442-key-path-unwrap-crash branch August 26, 2020 01:52
@LucianoPAlmeida
Copy link
Contributor Author

Thanks @hamishknight @xedin :)

@LucianoPAlmeida LucianoPAlmeida mentioned this pull request Aug 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishknight hamishknight hamishknight approved these changes

@xedin xedin Awaiting requested review from xedin

@hborla hborla Awaiting requested review from hborla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucianoPAlmeida @hamishknight @xedin