[IRGen] NFC: Simplify IRGenModule::defineTypeMetadata #33626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davezarzycki
requested review from
slavapestov,
jckarter,
rjmccall and
nate-chandler
|
@swift-ci please smoke test |
|
For whatever it may be worth, I found the "adjustment index" differences between the two functions to be quite confusing for a while. I assumed that it was code duplication but I was wrong. |
jckarter
reviewed
Aug 25, 2020
Also make `IRGenModule::getAddrOfTypeMetadata()` more clear that a GEP is being forced and optional aliasing is involved rather than imply that full metadata always requires a GEP (which it does not).
|
I can live with @swift-ci please smoke test |
|
The other changes LGTM. |
nkcsgexi
pushed a commit
to nkcsgexi/swift
that referenced
this pull request
Aug 29, 2020
[IRGen] NFC: Simplify IRGenModule::defineTypeMetadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make
IRGenModule::getAddrOfTypeMetadata()more clear that a GEP is being forced and optional aliasing is involved rather than imply that full metadata always requires a GEP (which it does not).