Skip to content

[build-toolchain] Add an option to control if code built by the toolchain links by default to the OS runtime or the toolchain runtime. #33639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

Today by default, we always link against the runtime runtime. This option just
lets our users decide what they want, but leaves the defaults alone.

@gottesmm gottesmm requested a review from shahmishal August 25, 2020 23:57
@gottesmm
Copy link
Contributor Author

@swift-ci build toolchain

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 0a795c27cf3c7bd57e6d29e2e88ce2337757d165

Install command
tar zxf swift-PR-33639-436-ubuntu16.04.tar.gz
More info

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci build toolchain OS X platform

…hain links by default to the OS runtime or the toolchain runtime.

Today by default, we always link against the runtime runtime. This option just
lets our users decide what they want, but leaves the defaults alone.
@gottesmm gottesmm force-pushed the pr-4725a682654c47d1c8fb22263805d3bef3ff9535 branch from 0a795c2 to af4199e Compare August 31, 2020 18:07
@gottesmm
Copy link
Contributor Author

@swift-ci build toolchain

1 similar comment
@gottesmm
Copy link
Contributor Author

@swift-ci build toolchain

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

3 similar comments
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - af4199e

Install command
tar zxf swift-PR-33639-442-ubuntu16.04.tar.gz
More info

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - af4199e

Install command
tar -zxf swift-PR-33639-665-osx.tar.gz --directory ~/

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test linux platform

Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@gottesmm gottesmm merged commit 8fb8178 into swiftlang:master Aug 31, 2020
@gottesmm gottesmm deleted the pr-4725a682654c47d1c8fb22263805d3bef3ff9535 branch August 31, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants