[Serialization] Serialize hasCReferences to keep linkage #33662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xymus
approved these changes
Aug 28, 2020
hasCReferences is used to determine that the function is externally available. If a function has @_cdecl and not used from anywhere in Swift side code, it will be emitted due to its hasCReferences. But if the attribute is not restored from sib, it won't be emitted even if it's used externally. So we need to serialize the attribute.
kateinoigakukun
force-pushed
the
katei/serialize-has-cref
branch
from
ec1589c to
992c383
Compare
|
@xymus Thanks for review! I rebased this branch 👍 |
|
@swift-ci Please smoke test |
|
Hmm, it seems linux CI failure is not related to this change. Could you trigger again? |
|
@swift-ci Please smoke test |
|
@swift-ci Please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasCReferences is used to determine that the function is externally
available. If a function has @_cdecl and not used from anywhere in Swift
side code, it will be emitted due to its hasCReferences. But if the
attribute is not restored from sib, it won't be emitted even if it's
used externally. So we need to serialize the attribute.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.