[CodeCompletion] Ensure all ExtensionDecl's extended types are computed #33669
Conversation
|
@swift-ci Please smoke test |
lib/IDE/ExprContextAnalysis.cpp
Outdated
| extensions.back()->computeExtendedNominal(); | ||
| extensions.pop_back(); | ||
| } | ||
| class ExtensionBinder: public ASTWalker { |
There was a problem hiding this comment.
Why does this traverse the AST instead of iterating over the top level declarations in a file or something?
There was a problem hiding this comment.
I thought we need to handle something like:
struct Something {
extension A: B.#^HERE^# {
}
But I didn't know this already has ErrorType as the extended type.
Will fix it.
There was a problem hiding this comment.
this already has ErrorType as the extended type.
Well, this is not true. But somehow
struct Something {
extension A: B.#^HERE^# {
}
doesn't crash. I will investigate.
There was a problem hiding this comment.
Malformed ASTs makes sense. Thanks.
There was a problem hiding this comment.
Ah, I see. Non-toplevel extension is canNeverBeBound(). So we don't need to compute the extended nominal unless it's top-level.
…uted Fixes an assertion failure in ASTScope lookup rdar://problem/67102794
rintaro
force-pushed
the
ide-completion-rdar67102794
branch
from
a3989ef to
e013ebd
Compare
| @@ -46,9 +46,11 @@ void swift::ide::typeCheckContextAt(DeclContext *DC, SourceLoc Loc) { | |||
| while (isa<AbstractClosureExpr>(DC)) | |||
| DC = DC->getParent(); | |||
|
|
|||
| // Make sure the extension has been bound, in case it is in an inactive #if | |||
| // or something weird like that. | |||
There was a problem hiding this comment.
Code completion never happens inside inactive #if since #33475
|
@swift-ci Please smoke test |
Fixes an assertion failure in ASTScope lookup
rdar://problem/67102794