Sema: Fix failure to emit diagnostic with some invalid member type references #33692
+90
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
another-invalid-nested-type-fix
branch
from
1952218 to
1e14e51
Compare
|
@swift-ci Please smoke test |
|
@swift-ci smoke test |
…ferences There were two problems here: - isUnsupportedMemberTypeReference() checked if the immediate parent type was an unbound generic type, but did not check for the parent of the parent, etc. - The caller of isUnsupportedMemberTypeReference() had to re-check the various invalid conditions to determine what diagnostic to emit, and if none of those conditions matched it would just return an ErrorType without emitting a diagnostic. Fix both of these by having isUnsupportedMemberTypeReference() return an enum indicating what went wrong, and handle more cases. Fixes <rdar://problem/67292528>.
slavapestov
force-pushed
the
another-invalid-nested-type-fix
branch
from
1e14e51 to
dcc27ea
Compare
|
@CodaFi It was totally my fault, I forgot to update a couple of testcases where diagnostics changed. |
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems here:
isUnsupportedMemberTypeReference() checked if the immediate parent type was
an unbound generic type, but did not check for the parent of the parent, etc.
The caller of isUnsupportedMemberTypeReference() had to re-check the
various invalid conditions to determine what diagnostic to emit, and if
none of those conditions matched it would just return an ErrorType without
emitting a diagnostic.
Fix both of these by having isUnsupportedMemberTypeReference() return an
enum indicating what went wrong, and handle more cases.
Fixes rdar://problem/67292528.