[docs] Clarify wording around adding new associatedtypes to protocols. #33696
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| availability), as long as it has a default implementation. | ||
| availability), as long as it has a default implementation. If the protocol | ||
| did not have one or more ``associatedtype`` requirements before the change, | ||
| then this is a `binary-compatible source-breaking change`. |
There was a problem hiding this comment.
Should these be double-backticks?
There was a problem hiding this comment.
I think this is right, double backticks are for formatting code, single backticks are for references. Elsewhere in this document:
nkcsgexi
approved these changes
Aug 31, 2020
harlanhaskins
approved these changes
Aug 31, 2020
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc Xi: I don't know if the API/ABI checkers already account for this, we might want to update them if they don't already do that.