IRGen: Ignore local variable declaration in inline c functions #33746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code that walks back the declcontext parents did not work
for local declarations:
```
static inline void func() {
extern int global;
...
}
```
The global's declaration context is the file context.
We would end up in code generation for the global decl and assert that
it is not a `isFileVarDecl()`.
rdar://67951491
|
@swift-ci Please test |
|
This seems to be the same as #33306. Most of the same comments apply. |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code that walks back the declcontext parents did not work
for local declarations:
The global's declaration context is the file context.
We would end up in code generation for the global decl and assert that
it is not a
isFileVarDecl().rdar://67951491