Skip to content

[Sanitizer] Symbolication test no inline #33753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

yln
Copy link
Contributor

@yln yln commented Sep 1, 2020

This test checks that Sanitizer reports contain properly symbolicated
stacks. Let's make sure that all of the expected frames appear in the
stack by disabling inlining.

rdar://68171463

@yln yln self-assigned this Sep 1, 2020
@yln
Copy link
Contributor Author

yln commented Sep 1, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Sep 2, 2020

Build failed
Swift Test Linux Platform
Git Sha - 0d30aca

This test checks that Sanitizer reports contain properly symbolicated
stacks.  Let's make sure that all of the expected frames appear in the
stack by disabling inlining and preventing tail call optimization.

rdar://68171463
@yln yln force-pushed the symbolication-test-no-inline branch from 0d30aca to 598276c Compare September 2, 2020 19:17
@yln
Copy link
Contributor Author

yln commented Sep 2, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Sep 2, 2020

Build failed
Swift Test Linux Platform
Git Sha - 0d30aca

@swift-ci
Copy link
Contributor

swift-ci commented Sep 2, 2020

Build failed
Swift Test OS X Platform
Git Sha - 0d30aca

@yln
Copy link
Contributor Author

yln commented Sep 2, 2020

Swift Test Linux shows up as failed, but I don't know why. All tests pass, including ours:

PASS: Swift(linux-x86_64) :: Sanitizers/symbolication-linux.swift (9337 of 13664)

@yln yln merged commit ac6dffd into master-rebranch Sep 2, 2020
@yln yln deleted the symbolication-test-no-inline branch September 2, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants