Skip to content

utils: add a timeout to the integration tests #33774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2020

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Sep 2, 2020

This will allow us to add test cases which may hang. The timeout here
is taken from the value we use in the regular test suite (along with the
check for the timeout requirements).

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

This will allow us to add test cases which may hang.  The timeout here
is taken from the value we use in the regular test suite (along with the
check for the timeout requirements).
@compnerd
Copy link
Member Author

compnerd commented Sep 2, 2020

CC: @gottesmm @shahmishal

Reduce timeout to 20m
@compnerd
Copy link
Member Author

compnerd commented Sep 2, 2020

Please test with following PRs:
swiftlang/swift-integration-tests#71

@swift-ci please test

Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compnerd
Copy link
Member Author

compnerd commented Sep 3, 2020

Please test with following PRs:
swiftlang/swift-integration-tests#71

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Sep 3, 2020

Build failed
Swift Test OS X Platform
Git Sha - 8125f77

@swift-ci
Copy link
Contributor

swift-ci commented Sep 3, 2020

Build failed
Swift Test Linux Platform
Git Sha - 9f01742

@compnerd
Copy link
Member Author

compnerd commented Sep 3, 2020

The Linux failure is expected with the new test (the hang should be resolved with #33770)

@compnerd
Copy link
Member Author

compnerd commented Sep 4, 2020

Please test with following PRs:
swiftlang/swift-integration-tests#71

@swift-ci please test Linux platform

@compnerd compnerd merged commit 2b67a9d into swiftlang:master Sep 4, 2020
@compnerd compnerd deleted the timeout branch September 4, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants