Skip to content

Make MinSizeRel builds produce debug info #33787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

kubamracek
Copy link
Contributor

MinSizeRel in CMake doesn't produce debug info by default, and there's no such thing as MinSizeRelWithDebInfo... So let's just make MinSizeRel produce debug info.

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek
Copy link
Contributor Author

@swift-ci please test stdlib with toolchain

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek
Copy link
Contributor Author

@swift-ci please test stdlib with toolchain

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek
Copy link
Contributor Author

@swift-ci please test stdlib with toolchain

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 5fdbf28

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 5fdbf28

@kubamracek kubamracek changed the base branch from master to main September 23, 2020 22:19
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that we are changing the semantics of the defaults, but this is probably almost always what you want.

@kubamracek kubamracek merged commit e6da0c2 into swiftlang:main Sep 24, 2020
@kubamracek kubamracek deleted the debug-minsizerel branch September 24, 2020 16:26
ainu-bot pushed a commit to google/swift that referenced this pull request Sep 24, 2020
* 'master' of github.com:apple/swift:
  Make MinSizeRel builds of stdlib (but not the compiler) produce debug info (swiftlang#33787)
  Add result checking to the ChaCha benchmark.
  [ConstraintSystem] Adjust overload filtering to be less aggressive in code completion mode
  Store Clang module imports in addition to Swift overlay.
  LLVM-Passes: add pointer authentication to Swift's function merge pass.
  Update doc and links to support new main branch
  [benchmark] Tweak naming and workload for two new tests
  [benchmark] Add another floating point conversion benchmark
  [benchmark] Add another test to floating point conversion benchmark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants