-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Make MinSizeRel builds produce debug info #33787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test |
@swift-ci please test stdlib with toolchain |
d1349d0
to
5fdbf28
Compare
@swift-ci please test |
@swift-ci please test stdlib with toolchain |
@swift-ci please test |
@swift-ci please test stdlib with toolchain |
Build failed |
Build failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like that we are changing the semantics of the defaults, but this is probably almost always what you want.
* 'master' of github.com:apple/swift: Make MinSizeRel builds of stdlib (but not the compiler) produce debug info (swiftlang#33787) Add result checking to the ChaCha benchmark. [ConstraintSystem] Adjust overload filtering to be less aggressive in code completion mode Store Clang module imports in addition to Swift overlay. LLVM-Passes: add pointer authentication to Swift's function merge pass. Update doc and links to support new main branch [benchmark] Tweak naming and workload for two new tests [benchmark] Add another floating point conversion benchmark [benchmark] Add another test to floating point conversion benchmark
MinSizeRel in CMake doesn't produce debug info by default, and there's no such thing as MinSizeRelWithDebInfo... So let's just make MinSizeRel produce debug info.