[AutoDiff] [Sema] Fix missing access-level mismatch diagnostic in -enable-testing builds.
#33800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nable-testing` builds. When a derivative function is internal and its original function is public, there should be an error when the derivative is not `@usableFromInline`. This patch fixes a bug where the error does not appear in SwiftPM debug build configurations (or any configurations with `-enable-testing`). `ValueDecl::getEffectiveAccess()` should not be used when we perform formal access checking for AutoDiff-related declaration attributes because it will treat all internal declarations as public when `-enable-testing` is enabled. Instea we should use a combination of `ValueDecl::getFormalAccess()` and `ValueDecl::isUsableFromInline()`. Also, add a `RUN` line with `-enable-testing` to all AutoDiff declaration attribute test files. Resolves SR-13500 (rdar://68336300).
|
@swift-ci please test |
dan-zheng
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a derivative function is internal and its original function is public, there should be an error when the derivative is not
@usableFromInline. This patch fixes a bug where the error does not appear in SwiftPM debug build configurations (or any configurations with-enable-testing).ValueDecl::getEffectiveAccess()should not be used when we perform formal access checking for AutoDiff-related declaration attributes because it will treat all internal declarations as public when-enable-testingis enabled. Instead, we should use a combination ofValueDecl::getFormalAccess()andValueDecl::isUsableFromInline().Also, add a
RUNline with-enable-testingto all AutoDiff declaration attribute test files.Resolves SR-13500 (rdar://68336300).