Add and use AbstractFunctionDecl::getTypecheckedBody #33806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bunch of callers were accidentally misusing it.
Refactor TypeCheckFunctionBodyRequest to return the type-checked body, and remove `typeCheckAbstractFunctionBody` in favor of a method on AbstractFunctionDecl. In addition, start returning an ErrorExpr body instead of a partially type-checked body if type-checking fails.
We no longer run error checking for already type-checked synthesized functions, so add a couple of `setThrows` calls where they were previously missing.
Use `getTypecheckedBody` to allow lazy type-checking when emitting function definitions.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
CodaFi
approved these changes
Sep 11, 2020
|
@swift-ci please test |
hamishknight
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Sep 11, 2020
hamishknight
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Sep 11, 2020
[master-next] Update for swiftlang/swift#33806
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
TypeCheckFunctionBodyRequestto return the type-checked body, and removetypeCheckAbstractFunctionBodyin favor of a method onAbstractFunctionDecl. In addition, start returning anErrorExprbody instead of a partially type-checked body if type-checking fails.Then, start using
getTypecheckedBodyin SILGen to allow lazy type-checking when emitting function definitions.