Skip to content

SILOptimizer: correct accidental >= to > #33808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Sep 4, 2020

This should be enabled for fileprivate classes. Thanks to
@slavapestov for pointing out the mistake in the condition!

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

This should be enabled for `fileprivate` classes.  Thanks to
@slavapestov for pointing out the mistake in the condition!
@compnerd
Copy link
Member Author

compnerd commented Sep 4, 2020

CC: @slavapestov

@compnerd
Copy link
Member Author

compnerd commented Sep 4, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Sep 4, 2020

Build failed
Swift Test OS X Platform
Git Sha - 0ee2201

@swift-ci
Copy link
Contributor

swift-ci commented Sep 4, 2020

Build failed
Swift Test Linux Platform
Git Sha - 0ee2201

@shahmishal
Copy link
Member

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

  • How to change the base branch: (Link)
  • More detail about the branch update: (Link)

@compnerd compnerd changed the base branch from master to main October 1, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants