Skip to content

[SourceKit] Reorganize code completion options #33811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2020
Merged

[SourceKit] Reorganize code completion options #33811

merged 1 commit into from
Sep 8, 2020

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Sep 4, 2020

  • Abolish reuseastcontext per-request option. Reusing ASTContext is essentially non per-request functionality.
  • Add MaxASTContextReuseCount global configuration instead.

@rintaro
[SourceKit] Reorgantize code completion options
77b4f75 
* Abolish 'reuseastcontext' per-request option
* Add 'MaxASTContextReuseCount' global configuration
@rintaro
Copy link
Member Author

rintaro commented Sep 4, 2020

@swift-ci Please smoke test

@rintaro rintaro requested a review from benlangmuir September 4, 2020 23:27
@rintaro
Copy link
Member Author

rintaro commented Sep 4, 2020

@swift-ci Please smoke test macOS

@rintaro rintaro changed the title [SourceKit] Reorgantize code completion options [SourceKit] Reorganize code completion options Sep 4, 2020
@rintaro
Copy link
Member Author

rintaro commented Sep 4, 2020

Just to note reuseastcontext=0 is technically different from completion_max_reuse_astcontext_count=0.
The latter holds the compiler instance until next invocation, and doesn't support simultaneous invocation (mutex locked).

But now that reuseastcontext=1 is the default and we are probably not going to disable it again. So I think it's not worth is to keep the behavior of reuseastcontext=0

@rintaro
Copy link
Member Author

rintaro commented Sep 4, 2020

@swift-ci Please smoke test macOS

@rintaro
Copy link
Member Author

rintaro commented Sep 8, 2020

@swift-ci Please test Windows

@rintaro
Copy link
Member Author

rintaro commented Sep 8, 2020

Windows failure is unrelated. Merging

@rintaro rintaro merged commit d2b70e4 into swiftlang:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlangmuir benlangmuir benlangmuir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @benlangmuir