Add a SWIFT_STDLIB_HAS_DARWIN_LIBMALLOC flag to allow/disallow uses of Darwin libmalloc APIs (malloc_default_zone, malloc_zone_malloc, etc.) #33812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test stdlib with toolchain |
mikeash
requested changes
Sep 8, 2020
include/swift/Runtime/Concurrent.h
Outdated
| @@ -601,7 +601,8 @@ template <class ElemTy> struct ConcurrentReadableHashMap { | |||
| /// Otherwise, just return the passed-in size, which is always valid even if | |||
| /// not necessarily optimal. | |||
| size_t goodSize(size_t size) { | |||
| #if defined(__APPLE__) && defined(__MACH__) | |||
| #if defined(__APPLE__) && defined(__MACH__) && \ | |||
| defined(SWIFT_STDLIB_HAS_DARWIN_LIBMALLOC) | |||
There was a problem hiding this comment.
You'll want this to just be SWIFT_STDLIB_HAS_DARWIN_LIBMALLOC (no defined() around it) to handle the case where it's 0.
…f Darwin libmalloc APIs (malloc_default_zone, malloc_zone_malloc, etc.)
kubamracek
force-pushed
the
darwin-libmalloc
branch
from
c13fd71 to
c137ab0
Compare
|
@swift-ci please test |
mikeash
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.