Skip to content

[docs] Deprecate Python 2 in build instructions #33819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

stevapple
Copy link
Contributor

Deprecate Python 2 in build instructions, since Python 2 is no longer suggested and required (according to #33651).

Resolves SR-NNNN.

@stevapple
Copy link
Contributor Author

@swift-ci Please smoke test

@stevapple
Copy link
Contributor Author

CC @compnerd

I think you've meant that Python 2 is no longer needed, including building and using Swift on Windows.

@stevapple stevapple changed the title Deprecate Python 2 in build instructions [docs] Deprecate Python 2 in build instructions Sep 5, 2020
@stevapple stevapple force-pushed the master branch 3 times, most recently from 0666a11 to f7c2e48 Compare September 5, 2020 09:07
@benrimmington
Copy link
Contributor

#33786 is moving the Ubuntu dependencies (from README.md to docs/HowToGuides/GettingStarted.md).

@stevapple
Copy link
Contributor Author

@benrimmington But I can do nothing before that PR is merged :(

@benrimmington
Copy link
Contributor

@stevapple You could:

@varungandhi-apple
Copy link
Contributor

varungandhi-apple commented Sep 5, 2020

There are still a couple of unresolved points in #33786 and Monday is a holiday in the US, so it'll probably be end-of-day Tuesday or Wednesday when I land that.

That said, I can update #33786 to reflect the changes here in README.md. (Done) If you changed only WindowsBuild.md in this PR, that would avoid merge conflicts and you could land this whenever it is approved.

@stevapple
Copy link
Contributor Author

@varungandhi-apple Done.

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up

@compnerd
Copy link
Member

compnerd commented Sep 6, 2020

@swift-ci please smoke test

@benrimmington benrimmington merged commit 3c5322d into swiftlang:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants