[test][IRGen] Maybe Windows needs dso_local. #33827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In swiftlang#33816, we forked the local_extern test omitting the check for the extern function, because it wasn't obvious what the match was. It might actually just be missing the dso_local annotation again for the function. Let's try that.
|
cc @compnerd. Can you run this through Windows CI? If it works, great. If not, then I'll try something else. |
|
@swift-ci please smoke test Windows platform |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Linux platform |
|
Okay, I finally have the build worked out again; Looking at this locally, yes, this looks like it was the issue. |
compnerd
approved these changes
Sep 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #33816, we forked the local_extern test omitting the check for the
extern function, because it wasn't obvious what the match was. It might
actually just be missing the dso_local annotation again for the
function. Let's try that.