[Changelog] Add SE-0284 #33828
Merged
[Changelog] Add SE-0284 #33828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
cc @rintaro |
theblixguy
reviewed
Sep 5, 2020
|
@swift-ci please smoke test |
tschuett
reviewed
Sep 6, 2020
| func foo(_ a: Int..., b: Double...) { } | ||
|
|
||
| struct Bar { | ||
| subscript(a: Int..., b b: Int...) -> [Int] { a + b } |
There was a problem hiding this comment.
subscript parameters are unlabeled by default, so the second parameter needs an explicit label since it follows a variadic parameter
CodaFi
approved these changes
Sep 11, 2020
|
Please fix the conflict here, then we can get this merged. |
owenv
force-pushed
the
284-changelog
branch
from
7bf8507 to
f234da6
Compare
|
Ah, sorry, been busy this week and hadn't gotten around to updating this @swift-ci please smoke test and merge |
|
@swift-ci please smoke test |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #29735