[Benchmark] Fix build failure on ARMv7 by guarding Float80 availability #33836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Ugh, sorry. This did not come up during CI testing. |
xwu
reviewed
Sep 7, 2020
|
@swift-ci please test |
It didn't come up because smoke testing doesn't run all the device tests. This is an annoyance when working on IRGen stuff due to minor differences between 64-bit and 32-bit platforms, so I generally run swift-ci test unless I have strong reason to think there is no platform-specific stuff in the PR. |
|
Yes, I would run the full tests for any changes to the compiler, but since the benchmarks here involved only implementing user-facing APIs, things seemed all good when both the full benchmarks and the smoke tests passed. Lesson learned. This is a user-facing footgun that we need a better solution for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative fix for benchmark build failure caused by #33821 on ARMv7.