WinSDK: add Shell32 #33849
Merged
WinSDK: add Shell32 #33849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This header and .lib features useful APIs such as [SHFileOperation](https://docs.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-shfileoperationw), which seems to be the preferred way to manipulate file systems for certain things.
|
@swift-ci smoke test |
|
@swift-ci smoke test Windows Platform |
|
smoke test Linux Platform |
compnerd
reviewed
Sep 8, 2020
There was a problem hiding this comment.
Hmm, I'm wondering if we want to rename the old module or not. The original module is the lightweight Shell API, and this is the full one. Either way, as long as it builds, this seems reasonable, but I would like to test the build locally, since we're missing coverage on Foundation :(. I learnt the hard way with the last rebranch.
|
ah. The only test I ran locally is modifying the installed .modulemap and use one of the APIs in the local build. It appeared to have worked well. |
|
@swift-ci smoke test Linux Platform |
compnerd
approved these changes
Sep 10, 2020
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This header and .lib features useful APIs such as SHFileOperation, which seems to be the preferred way to manipulate file systems for certain things.