[benchmark] Delete two benchmarks and add generic floating-point conversion lit tests #33853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@swift-ci test macOS platform |
|
@swift-ci test Linux platform |
|
@eeckstein First time writing a SIL optimizer test for me; just want to make sure all's kosher here. |
eeckstein
approved these changes
Sep 9, 2020
|
|
||
| // CHECK-LABEL: sil @$s4test0A13DoubleToFloatySfSdF | ||
| // CHECK: bb0(%0 : $Double): | ||
| // CHECK: struct_extract %0 : $Double, #Double._value |
There was a problem hiding this comment.
The usual way to check this is to use patterns for the values, e.g.
[[ARG:%[0-9]+]] = struct_extract %0
[[CONV:%[0-9]+]] = builtin "fptrunc_FPIEEE64_FPIEEE32"([[ARG]])
...
But doing it with CHECK-NEXT is perfectly fine for this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on #33801 and #33839 by removing benchmarks that are unnecessary now that lit tests check that the optimization is, well, optimal for generic
Double-to-Doubleconversion.In addition, I have added two additional checks to floating_point_conversion.swift to ensure that generic
Double-to-FloatandFloat-to-Doubleconversions are also optimized as expected.