GSB: Watch out for a concrete ResolvedType in ArchetypeType::resolveNestedType #33859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
commented
Sep 8, 2020
Comment on lines
+2637
to
2641
| /*wantExactPotentialArchetype=*/false); | ||
| if (!resolved) { | ||
| nested.second = ErrorType::get(interfaceType); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Should we assert instead?
|
@slavapestov ping |
|
I'll take a look at this shortly. I think another dupe of this came in recently. |
|
Sorry for the pinging, I somehow missed you self-assigned this. |
This was referenced Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SR-13519
The regression was caused by 653fa07, apparently. Under certain conditions,
maybeResolveEquivalenceClasswould look into the superclass of the base equiv. class to find a nested type, resulting in a concreteResolvedTypethat is not associated with an equivalence class.resolveEquivalenceClassand at least one of its clients were not expecting this to happen.