[AutoDiff] Fix forward-mode crashes related to tangent buffers #33868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes foward-mode crashed related to: - Missing tangent buffers for non-wrt `inout` parameters. - Tangent buffers not being initialized due to the corresponding original buffer intialization instructions being non-active. - Non-varied indirect results not being initialized. - `emitDestroyValue` crashes due to `TangentVector` value category mismatch. Resolves TF-984 and SR-13447. Co-authored-by: Dan Zheng <[email protected]>
|
@swift-ci Please test tensorflow |
efremale
approved these changes
Sep 9, 2020
|
@swift-ci Please test tensorflow |
1 similar comment
|
@swift-ci Please test tensorflow |
|
Test failures are known (missing CI machine dependencies) and unrelated. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #33633 to
tensorflowbranch.Fixes foward-mode crashed related to:
inoutparameters.buffer intialization instructions being non-active.
emitDestroyValuecrashes due toTangentVectorvalue category mismatch.Resolves TF-984 and SR-13447.