[Sema] Check that at least one buildBlock is callable given arg labels
#33885
Conversation
| if (!argLabels.empty()) { | ||
| auto funcLabels = func->getName().getArgumentNames(); | ||
| if (argLabels.size() > funcLabels.size() || | ||
| funcLabels.slice(0, argLabels.size()) != argLabels) { |
There was a problem hiding this comment.
This is an approximation of the rule used to actually match call arguments. Do you want to go all the way and use matchCallArguments to get it exactly right?
There was a problem hiding this comment.
I think that makes sense for most of the build* functions (since the transform introduces a fixed number of arguments), but I don't think it would work for buildBlock since we won't know the correct number of arguments until we're actually evaluating a call, and every call to buildBlock may differ in the number of arguments.
It seems to me that, given that buildBlock calls may have an unbounded number of arguments (of any type), the best we can do when evaluating the buildBlock declaration is make sure that there are no required labeled arguments. If I'm missing something let me know!
Jumhyn
force-pushed
the
function-builder-buildblock-arg-labels
branch
from
ebe951f to
0bb6b0f
Compare
When validating an @_functionBuilder type, reject types which only provide `buildBlock` declarations with argument labels (which don't have default values). These declarations will never be callable by the `buildBlock` calls produced by the function builder transformation, which does not insert any argument labels for `buildBlock` calls.
Jumhyn
force-pushed
the
function-builder-buildblock-arg-labels
branch
from
0bb6b0f to
81d8ee0
Compare
|
@DougGregor Updated this to incorporate changes from #33972, still interested in your thoughts on the thread above! |
|
@DougGregor Could you give this another look when you have the chance? |
When validating an @_functionBuilder type, reject types which only provide
buildBlockdeclarations with argument labels (which don't have default values). These declarations will never be callable by thebuildBlockcalls produced by the function builder transformation, which does not insert any argument labels forbuildBlockcalls.