Skip to content

[AutoDiff] Generate transparent ossa reabstraction thunks. #33897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

dan-zheng
Copy link
Contributor

Cherry-pick of #33854 to tensorflow branch.
Unblocks building tensorflow/swift-apis with forward-mode differentiation enabled.


Make the differentiation transform generate transparent, ossa
reabstraction thunks.

This enables these thunks to be inlined into other ossa functions (e.g.
generated VJP and pullback functions) during mandatory inlining.

Resolves TF-989.
Unblocks further autodiff-related optimizations: SR-13390.

Make the differentiation transform generate transparent, ossa
reabstraction thunks.

This enables these thunks to be inlined into other ossa functions (e.g.
generated VJP and pullback functions) during mandatory inlining.

Resolves TF-989.
Unblocks further autodiff-related optimizations: SR-13390.
@dan-zheng dan-zheng added the tensorflow This is for "tensorflow" branch PRs. label Sep 10, 2020
@dan-zheng
Copy link
Contributor Author

@swift-ci Please test tensorflow

@dan-zheng
Copy link
Contributor Author

CI machines are down, but internal CI passed. Merging to unblock progress.

@dan-zheng dan-zheng merged commit 49652f0 into tensorflow Sep 11, 2020
@dan-zheng dan-zheng deleted the tensorflow-autodiff branch September 11, 2020 01:52
dabrahams pushed a commit to google/swift that referenced this pull request Sep 14, 2020
* 'tensorflow' of github.com:apple/swift:
  [AutoDiff] Generate transparent ossa reabstraction thunks. (swiftlang#33897)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant