SILParser: Fix for removal of parse-time name lookup #33922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parse-time lookup is disabled, we can't rely on the parser binding IdentTypeReprs that name generic parameters, so we do it in type resolution by having the SIL parser supply a GenericParamList.
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
sil-parser-overhaul
branch
from
622e064 to
42ec069
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
zoecarver
reviewed
Sep 11, 2020
lib/Sema/TypeCheckType.cpp
Outdated
| for (auto &fieldRepr : repr->getFields()) { | ||
| fieldRepr.getFieldType()->dump(); |
There was a problem hiding this comment.
Remnants of a debug session?
There was a problem hiding this comment.
Yes, thank you!
slavapestov
force-pushed
the
sil-parser-overhaul
branch
from
42ec069 to
dbdbbff
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
Build failed |
slavapestov
changed the title
|
@swift-ci Please smoke test Linux |
1 similar comment
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SIL parser parses "dismebodied"
GenericParamLists that are not associated with aDecl, and do not appear in the ASTScope tree. The parser would bindIdentTypeReprs that referenced these generic parameter lists using parse-time lookup.In order to make this work when parse-time lookup is disabled, we have to plumb
GenericParamLists through the SIL parser in various places, and also teach Sema'sresolveType()to handle them.