[NFC] Refactor InputFile #33926
Merged
[NFC] Refactor InputFile #33926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameter here was derived from the CompilerInvocation-level parsing bits, which doesn't make any sense. This state is going away soon, so drop the parameter.
|
@swift-ci test |
|
Build failed |
Add a new constructor that takes an explicit file_type::ID to allow for the eventual deletion of InputFileKind.
Tying InputFile to this option meant that every input that was not one of the explictly-blessed kinds was modeled as a Swift file. With the new InputFile that infers file kinds, we no longer need CompilerInvocation::setInputKind
CodaFi
force-pushed
the
just-my-kind
branch
from
51acef9 to
3287c4b
Compare
|
Build failed |
|
Build failed |
|
@swift-ci test Windows |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
InputFileby expanding its documentation, normalizing its accessors and constructors, and scrubbing the frontend of the legacy ofInputFileKind, which incorrectly constricted the "kinds" of input files the frontend could accept.