[Profiler] Increment closure body count prior to the prolog #33946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a 'SILBuilder has no valid insertion point' assertion failure seen when compiling various projects from the source compat suite. rdar://68759819
|
@swift-ci Please Test Source Compatibility Debug |
|
@swift-ci smoke test |
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please smoke test macOS platform |
eeckstein
approved these changes
Sep 15, 2020
|
Looks like the changes didn’t fix the problem and release version is failing too now, I am going to merge my xfails to unblock CI while this is being investigated. |
|
It looks like there's more than one bug uncovered by Erik's assert. I'll merge this first fix now and investigate the second failure. |
This was referenced Sep 15, 2020
dabrahams
pushed a commit
that referenced
this pull request
Sep 15, 2020
* 'master' of github.com:apple/swift: [docs] Fix broken links in the documentation index (#33829) [Profiler] Increment closure body count prior to the prolog (#33946) ARCSequenceOpts: Add LoopSummary verifier (#33810) [build-script] Cleanup source directory layout help Address review comment. ABI checker: when invoking via build system, explicitly mention ABI breakge in diagnostics stdlib: Remove unused, unsafe helper function _withUninitializedString (#33704) test: Replace _silgen_name w/ _cdecl in CommandLineStressTest [AutoDiff] [Docs] Clarify 'Differentiable' derived conformances conditions. Revert "build-script: remove dead CMake options for Swift"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a 'SILBuilder has no valid insertion point' assertion failure
seen when compiling various projects from the source compat suite.
rdar://68759819