Introduce SymbolObjectCodeRequest #33954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
CodaFi
reviewed
Sep 15, 2020
CodaFi
approved these changes
Sep 15, 2020
Remove the type-checking call from OptimizedIRRequest, and sink it down into SILGen and IRGen when we come to emit the source files.
Rename the member on ASTLoweringDescriptor and IRGenDescriptor to make it more explicit it returns the files that need emitting, rather than just the files that happen to be present. This distinction will become important once we start emitting code only for a specific set of symbols.
Extend ASTLoweringDescriptor to store a set of SILDeclRefs to emit through `emitFunctionDefinition`.
Add SymbolObjectCodeRequest, which emits object code for a specific set of symbols by querying TBDGen for the source of the symbols, and asking SILGen (and eventually IRGen) to emit them.
hamishknight
force-pushed
the
sym-city-two
branch
from
ddb76f0 to
088a86e
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SymbolObjectCodeRequest, which emits object code for a specific set of symbols by querying TBDGen for the source of the symbols, and asking SILGen (and eventually IRGen) to emit them.