Add an cplusplus_driver lit feature for use with tests not supported by swift-driver #33961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
The terminology here is confusing to me. I've been using "integrated driver" to talk about swift-driver when it is integrated into the build system (SwiftPM), whereas here you are using it to refer to the C++ driver. Could we come up with another term here? |
This will be used to mark tests as REQUIRES: cplusplus_driver if they cannot be easily made to work with swift-driver due to architectural differences (for example, the lack of -driver-print-actions), and the test cases have been ported to XCTest This feature is enabled if the swift_driver param is NOT passed to lit.py
owenv
force-pushed
the
swift-driver-lit-feature
branch
from
dc3339d to
28ad7f2
Compare
owenv
changed the title
|
cplusplus_driver sounds good to me! I was thinking integrated as in "integrated with the frontend", but this does seem a lot clearer to anyone encountering it later. |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
artemcm
approved these changes
Sep 16, 2020
DougGregor
approved these changes
Sep 16, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used to mark tests as REQUIRES: integrated_driver if they cannot be easily made to work with swift-driver due to architectural differences (for example, the lack of -driver-print-actions and -driver-print-bindings), and the test cases have been ported to XCTest in the swift-driver repo.
This feature is enabled if the swift_driver param is NOT passed to lit.py
Now that swift-driver only fails ~200 integration tests, I think it makes sense to put more effort into porting some of these test cases to XCTest and excluding them when using swift-driver, so we have a better measure of our progress towards parity with the integrated version.