[Sema] Accept the use of SPI in SPI inlinable code #33970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://63978500 rdar://63189125
Dummy conformances are generated when a conditional conformance is constrained by a type that is not to be printed. In case the types involved are SPI, mark the dummy conformance SPI in the private swiftinterface only.
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the use of SPI declarations within SPI inlinable code, default values for arguments and frozen property initializers. This makes the compiler generate
@_spiattributes where they would have previously been rejected so accept all explicit@_spiattributes in SPI contexts. To test all of this and more, we also check the swiftinterfaces generated bySPI/private_swiftinterface.swiftwith-typecheck-module-from-interface.rdar://63978500&63189125