[CodeCompletion] Calculate type relation when adding type annotation #33978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculate and set the type relation in each result building logic which knows the actual result type. CodeCompletionResultBuilder couldn't know the actual result type. From the declaration alone, it cannot know the correct result type because it doesn't know how the declaration is used (e.g. calling? referencing by compound name? curried?)
|
@swift-ci Please smoke test |
benlangmuir
reviewed
Sep 17, 2020
| @@ -2490,7 +2430,7 @@ class CompletionLookup final : public swift::VisibleDeclConsumer { | |||
| } | |||
| } | |||
|
|
|||
| return eraseArchetypes(T, GenericSig); | |||
| return T; | |||
There was a problem hiding this comment.
I'm curious: how did you ensure that every place that needs to eraseArchetypes in addTypeAnnotation has the correct generic signature passed in, especially since the generic signature is optional for that method? Did you make it non-optional and check every call, or was there some other approach?
There was a problem hiding this comment.
I just checked all usages of getTypeOfMember() and passed DC->getGenericSignatureOfContext() to type printing functions (addCallArgumentPatterns() and addTypeAnnotation()).
benlangmuir
approved these changes
Sep 17, 2020
nathawes
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate and set the type relation in each result building logic which knows the actual result type.
CodeCompletionResultBuildercouldn't know the actual result type. From the declaration alone, it cannot know the correct result type because it doesn't know how the declaration is used (e.g. calling? referencing by compound name? curried?)(#33749 (comment))