Skip to content

[semantic-arc] Fix an initialization thinko. #33983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

Just doing this quickly to prevent the bots from breaking. We still were using
the default instModCallbacks that do remove/RAUW/etc, but do not update data
structures.

Just doing this quickly to prevent the bots from breaking. We still were using
the default instModCallbacks that do remove/RAUW/etc, but do not update data
structures.
@gottesmm gottesmm requested a review from lorentey September 17, 2020 22:40
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@lorentey this is what I was talking about. I hope this lands before anything breaks!

@gottesmm
Copy link
Contributor Author

I have a separate patch that uses my coroutine lifetime extender work that trips on this. But I need to write more tests and I want to make sure the blocks aren't broken due to this.

@gottesmm
Copy link
Contributor Author

Going to merge this to ensure the bots don't break

@gottesmm gottesmm merged commit 4258267 into swiftlang:master Sep 18, 2020
@gottesmm gottesmm deleted the pr-40b05a478548bd5fb2304ea73034fe9ff542c9d4 branch September 18, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant