ASTScope: Clean up IfConfigDecl handling and a couple of other things #34026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're always guaranteed to visit the elements of the active clause as members of the parent AST node.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
davidungar
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
historyvector passed down through lookup was only used for theselfDCandisCascadingcomputations, both of which are now gone.IfConfigDeclare visited as part of their parent, so we don't have to walk intoIfConfigDecls at all.ParameterListScopeis only used as a parent for default argument initializer scopes, and doesn't bind any names, so it can be a sibling rather a parent of theFunctionBodyScope, which simplifies some source range computations.