Skip to content

WinSDK: extract Printing submodule #34032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Conversation

egorzhdan
Copy link
Contributor

Currently winspool.h gets included into WinSDK.WinSock2 via windows.h.
However it is not directly related to sockets.
This change makes it a separate submodule.

Currently winspool.h gets included into `WinSDK.WinSock2` via windows.h
@egorzhdan egorzhdan requested a review from compnerd September 22, 2020 18:53
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compnerd
Copy link
Member

@swift-ci please smoke test

1 similar comment
@compnerd
Copy link
Member

@swift-ci please smoke test

@compnerd
Copy link
Member

@swift-ci please smoke test macOS platform

1 similar comment
@compnerd
Copy link
Member

@swift-ci please smoke test macOS platform

@egorzhdan egorzhdan changed the base branch from master to main September 23, 2020 08:32
@compnerd
Copy link
Member

@swift-ci please smoke test macOS platform

@compnerd compnerd merged commit 846f522 into swiftlang:main Sep 24, 2020
@egorzhdan egorzhdan deleted the winsdk-printing branch September 30, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants