LLVM-Passes: add pointer authentication to Swift's function merge pass. #34033
Conversation
|
@swift-ci test |
|
Build failed |
|
Build failed |
| @@ -316,6 +325,15 @@ class SwiftMergeFunctions : public ModulePass { | |||
| CurrentInst = &*std::next(CurrentInst->getIterator()); | |||
| } | |||
|
|
|||
| /// Returns true if the operand \p OpIdx of the current instruction is the | |||
| /// callee of a call, which needs to be signed if passed as a parameter. | |||
There was a problem hiding this comment.
Oh, you might have a similar problem with the ptrauth intrinsics — you shouldn't turn a constant operand of llvm.ptrauth.sign (which we have to do when e.g. storing into an address-diversified location) into a non-constant one. You'll need to turn the sign into a resign.
There was a problem hiding this comment.
Intrinsics are excluded from being parameterized, anyway.
There was a problem hiding this comment.
Okay, if the parameterization only happens with function calls and not other uses of functions, then yeah, this isn't a problem.
There was a problem hiding this comment.
Oh, I see, parameterization also doesn't consider uses by intrinsics.
| @@ -337,12 +355,25 @@ class SwiftMergeFunctions : public ModulePass { | |||
| /// All uses of the parameter in the merged function. | |||
| SmallVector<OpLocation, 16> Uses; | |||
|
|
|||
| /// The discriminator for pointer signing. | |||
| /// Only not null, if needsPointerSigning is true. | |||
| // Replace all differing operands, which need pointer signing, with a | ||
| // parameter. | ||
| // We need to do that after all other parameters, because here we replace | ||
| // call instructions, which must be life in case it has another constant to |
If during merging a function pointer is passed as a parameter to the merged function, it needs to be signed on arm64e. rdar://problem/66797689
eeckstein
force-pushed
the
merge-func-ptrauth
branch
from
554a4c3 to
e4e5484
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
If during merging a function pointer is passed as a parameter to the merged function, it needs to be signed on arm64e.
rdar://problem/66797689