Store Clang module imports in addition to Swift overlay. #34037
Conversation
|
@swift-ci test and merge |
lib/IRGen/IRGenDebugInfo.cpp
Outdated
| void createImportedModule(llvm::DIScope *Context, | ||
| ModuleDecl::ImportedModule M, llvm::DIFile *File, | ||
| unsigned Line) { | ||
| // For cross-import overlay modules also emit an import of the underlying |
There was a problem hiding this comment.
micro-nit: This seems to apply to regular overlays, not cross-import overlays, right?
There was a problem hiding this comment.
Maybe I'm getting confused about the terminology here: I thought that cross-import overlay is synonymous with that it has an underlying Clang module?
There was a problem hiding this comment.
Nope, that's just a regular overlay. A cross-import overlay is e.g. the _MapKit_SwiftUI module in the SDK, it doesn't necessarily need to involve clang modules at all.
There was a problem hiding this comment.
Yeah, but the code explicitly checks for an underlying Clang module so I'm not yet sure I understand the concern?
There was a problem hiding this comment.
Oh the only concern is that the comment is misleading 😅
There was a problem hiding this comment.
That's what I don't get (yet) — the comment says cross-module overlays get an extra reference to the underlying clang module and the code only applies to modules with underlying clang modules.
There was a problem hiding this comment.
Right, but does this only apply to cross-import overlays of clang modules? This seems to apply mostly to regular overlays, I can't see anything that makes this specific to cross-import overlays.
There was a problem hiding this comment.
Can you explain what the difference between a cross-import overlay of a clang module and a regular overlay of a clang module is? This is what isn't clear to me.
There was a problem hiding this comment.
A cross-import of a clang module would involve additional metadata bundled with the swiftmodule structure that describes the other modules it can cross-over with. I don't know if we have any examples of one half of the cross being a pure clang module that is not adulterated by a Swift overlay module.
A plain overlay is a Swift module that imports an underlying clang module with the same name and extends declarations contained therein.
There was a problem hiding this comment.
Ok! So "Cross" is an orthogonal concept to the source language of the module. Which is what Harlan said a couple of comment above I now realize... thanks!
|
@swift-ci test and merge |
1 similar comment
|
@swift-ci test and merge |
|
@swift-ci test and merge |
This helps the debugger resolve types in the underlying Clang module. <rdar://problem/69393097>
adrian-prantl
force-pushed
the
69393097
branch
from
9f210c6 to
ba4c82d
Compare
|
@swift-ci smoke test |
|
test with swiftlang/llvm-project#1836 |
This helps the debugger resolve types in the underlying Clang module.
rdar://problem/69393097
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.