[Concurrency] Handle partial application of actor-isolated methods. #34051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
theblixguy
reviewed
Sep 23, 2020
|
Might be worth adding some SILGen tests for the valid cases. |
We don't have any SILGen support for asynchronous functions yet, so we can't write these tests meaningfully. |
|
Windows issue is unrelated: |
Replace a hand-rolled variant of the subject function used for actor isolation checking with a call to it. This exposed some limitations of the function, which would assert() when dealing with partial applications that involved optionals. Fix those as well.
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test Linux |
|
Source compatibility suite testing is still being adjusted for the master -> main transition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement appropriate isolation checking for partial application of actor-isolated methods.