[ConstraintSystem] Adjust overload filtering to be less aggressive in … #34052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
commented
Sep 23, 2020
xedin
force-pushed
the
avoid-overload-filtering-when-completing
branch
from
002f4e4 to
9b7d205
Compare
… code completion mode Avoid filtering overloads for calls which have code completion token as an argument, that would always undesired results, because such calls could be missing arguments before or after the token.
xedin
force-pushed
the
avoid-overload-filtering-when-completing
branch
from
9b7d205 to
a4701f7
Compare
|
@swift-ci please smoke test |
nathawes
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… code completion mode
Avoid filtering overloads for calls which have code completion
token as an argument, that would always undesired results,
because such calls could be missing arguments before or after
the token.