Skip to content

[NFC] Some Uncontroversial Frontend Refactorings #34059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2020
Merged

[NFC] Some Uncontroversial Frontend Refactorings #34059

merged 3 commits into from
Sep 24, 2020

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Sep 24, 2020

  • Privatize a header that was needlessly part of libAST's includes
  • Refine the return type of loadAST - this is needed for some upcoming work on incremental builds
  • Generalize SourceFileDeclFinder to remove the hard dependency on a SourceFile as the source of decls for dependencies

@CodaFi
[NFC] Privatize FrontendSourceFileDepGraphFactory.h
dd1ea9a
@CodaFi
[NFC] Refine the Return Type of SerializedModuleLoaderBase::loadAST
e0d67f4 
This grants access to the name of the loaded file to clients, which will be important for the upcoming cross-module incremental build experiments.
@CodaFi
Generalize SourceFileDeclFinder
7c256f2 
Strip mention of the SourceFile. Any FileUnit-esque thing that can provide top-level decls and `lookupClassMembers` works here - especially a ModuleDecl.
@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 24, 2020

@swift-ci smoke test

davidungar
davidungar approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@davidungar davidungar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the title! And these are great changes.

I'm assuming these changes came up as you were looking at cross-module dependencies. If they are a prerequisite for that work, you could mention that in the PR description as a help for future maintainers.

@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 24, 2020

@swift-ci smoke test

@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 24, 2020

⛵

@CodaFi CodaFi merged commit 7d80ae4 into swiftlang:main Sep 24, 2020
@CodaFi CodaFi deleted the graphics-card branch January 13, 2021 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidungar davidungar davidungar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodaFi @davidungar