Skip to content

Move explicit module frontend options out of the set of flags emitted into module interfaces. #34071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Sep 24, 2020

They never belonged there and were placed there by accident.

@artemcm artemcm requested a review from beccadax September 24, 2020 23:25
@artemcm
Copy link
Contributor Author

artemcm commented Sep 24, 2020

@swift-ci please test

Copy link
Contributor

@beccadax beccadax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but unfortunately, I'm about to cause a merge conflict: #34068

@artemcm
Copy link
Contributor Author

artemcm commented Sep 24, 2020

Looks good, but unfortunately, I'm about to cause a merge conflict: #34068

I'll rebase after, thanks for the heads up. 👍

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b7c6fda0e7d83fe05c7fe3028b8bcf9533706d92

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b7c6fda0e7d83fe05c7fe3028b8bcf9533706d92

@artemcm artemcm force-pushed the MoveOptionsOutOfTheInterfaceWay branch from b7c6fda to 98c871b Compare September 25, 2020 14:50
@artemcm
Copy link
Contributor Author

artemcm commented Sep 25, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 98c871be15680e76d3ac9d3c5ed7fbef5f17393a

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 98c871be15680e76d3ac9d3c5ed7fbef5f17393a

… into module interfaces.

They never belonged there and were placed there by accident.
@artemcm artemcm force-pushed the MoveOptionsOutOfTheInterfaceWay branch from 98c871b to 692fdde Compare September 28, 2020 17:06
@artemcm
Copy link
Contributor Author

artemcm commented Sep 28, 2020

@swift-ci please test

2 similar comments
@artemcm
Copy link
Contributor Author

artemcm commented Sep 28, 2020

@swift-ci please test

@artemcm
Copy link
Contributor Author

artemcm commented Sep 28, 2020

@swift-ci please test

@artemcm artemcm merged commit f0e7fd6 into swiftlang:main Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants