Serialization for Incremental Swift Dependency Information #34073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take advantage of the binary swiftdeps serialization utliities built during swiftlang#32131. Add a new optional information block to swiftdeps files. For now, don't actually serialize swiftdeps information. Frontends will use this information to determine whether to write incremental dependencies across modules into their swiftdeps files. We will then teach the driver to deserialize the data from this section and integrate it into its incremental decision making.
This has the net effect of only recording cross-module dependency information in the current module if the module under scrutiny can possibly provide dependency information of its own. For now, because none of this is turned on, this does not actually record additional dependencies from extant modules.
Invert the responsibility of the entrypoint so that FrontendTool is directing the actual serialization work. The entrypoint now solely exists to construct a dependency graph. While I'm here, prepare the way for serializing dependency graphs for modules by optimistically modeling a ModuleOrSourceFile input.
|
@swift-ci smoke test |
|
⛵ |
davidungar
reviewed
Sep 25, 2020
| g.emitDotFile(outputPath, diags); | ||
|
|
||
| return hadError; | ||
| bool fine_grained_dependencies::withReferenceDependencies( |
There was a problem hiding this comment.
What does this function do with the reference dependencies?
It looks like in constructs the graph and passes that to the continuation, is that right?
In any event, (in some future PR), a very in the name would aid comprehension.
There was a problem hiding this comment.
OK, after seeing the use, I understand the name better. But the current name still doesn't reveal that this function builds the graph.
davidungar
reviewed
Sep 25, 2020
Comment on lines
+1388
to
+1397
| SF, *Instance.getDependencyTracker(), outputPath, alsoEmitDotFile, | ||
| [&](SourceFileDepGraph &&g) -> bool { | ||
| const bool hadError = | ||
| fine_grained_dependencies::writeFineGrainedDependencyGraphToPath( | ||
| Instance.getDiags(), outputPath, g); | ||
|
|
||
| // If path is stdout, cannot read it back, so check for "-" | ||
| assert(outputPath == "-" || g.verifyReadsWhatIsWritten(outputPath)); | ||
|
|
||
| if (alsoEmitDotFile) |
There was a problem hiding this comment.
Is alsoEmitDotFile being passed needlessly to withReferenceDependencies?
|
Very cool! |
CodaFi
added a commit
to CodaFi/swift
that referenced
this pull request
Sep 25, 2020
This completes the missing piece from swiftlang#34073 and means the frontend may now serialize moduledecl-based dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't turn anything on yet, it just moves the necessary pieces into place.